Fix readTextureToTextureViews for multisampled textures#4049
Merged
greggman merged 1 commit intogpuweb:mainfrom Nov 19, 2024
Merged
Fix readTextureToTextureViews for multisampled textures#4049greggman merged 1 commit intogpuweb:mainfrom
greggman merged 1 commit intogpuweb:mainfrom
Conversation
kainino0x
approved these changes
Nov 19, 2024
I'm not sure when this bug was introduced. These tests used to pass. Fixed the bug and Added a test to hopefully find it quicker if it breaks in the future. Also added a test for createTextureWithRandomDataAndGetTexels with a generator. This was fixed in a previous PR without a a specific test as the fact that it failed other tests showed it needed fixing but I decided it's probably best to keep these tests too.
greggman
force-pushed
the
fix-readTextureToTexelViews-multisampled
branch
from
e018013 to
1383d3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure when this bug was introduced. The tests this broke used to pass (
textureLoad:multisampled). Fixed the bug and added a test to hopefully find it quicker if it breaks in the future.Also added a test for
createTextureWithRandomDataAndGetTexelswith a generator. This was fixed in a previous PR without a a specific test as the fact that it failed other tests showed it needed fixing but I decided it's probably best to keep these tests too.