Skip to content

Conversation

@kainino0x
Copy link
Collaborator

New tests passing in Chrome, failing in Safari (as expected), and passing in Firefox except for OOM which already wasn't working.

Issue: fixes #4361


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x requested a review from mwyrzykowski April 19, 2025 04:13
Copy link
Contributor

@mwyrzykowski mwyrzykowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kainino0x kainino0x enabled auto-merge (squash) April 21, 2025 18:36
@kainino0x kainino0x disabled auto-merge April 21, 2025 18:36
@kainino0x kainino0x enabled auto-merge (squash) April 21, 2025 18:36
@kainino0x kainino0x merged commit ffad382 into gpuweb:main Apr 21, 2025
1 check passed
@kainino0x kainino0x deleted the onuncapturederror branch April 21, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for device.onuncapturederror

2 participants