Add some tests related to GPUDevice extending EventTarget #4389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
May 20, 2025
Collaborator
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
Note: I made Fixture.expect take a function. If function was passed and no msg was provided then it uses the source of the function as the string. This makes it nice for small tests to see what passed/failed. Without this all you get is OK/FAIL and you need to provide a message.
doh, that's a good idea! when I was originally bringing up the CTS I really wanted something that would show nicer results for asserts (like https://github.com/power-assert-js/power-assert but that was too hard to integrate). Never thought of this for some reason.
lgtm!
* Test you can pass Event and CustomEvent through GPUDevice. * Test if you override a method on EventTarget it's called when you call the corresponding method on GPUDevice. * Test if you can pass GPUUncapturedErrorEvent through an EventTarget that is not GPUDevice Note: dawn.node fails these tests. It's not clear if NAPI makes this possible at all :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These pass on Chrome, Firefox, and Safari. dawn.node fails these tests though I have a patch that makes it work.
Note: I made Fixture.expect take a function. If function was passed and no msg was provided then it uses the source of the function as the string. This makes it nice for small tests to see what passed/failed. Without this all you get is OK/FAIL and you need to provide a message.
Example:
wdyt?