Add vec function var uniformity cases#4630
Merged
sudonatalie merged 2 commits intogpuweb:mainfrom Apr 27, 2026
Merged
Conversation
|
Results for build job (at d6bad03): -webgpu:shader,validation,uniformity,uniformity:function_variables:* - 201 cases, 201 subcases (~1/case)
+webgpu:shader,validation,uniformity,uniformity:function_variables:* - 246 cases, 246 subcases (~1/case)
-TOTAL: 281182 cases, 2322747 subcases
+TOTAL: 281227 cases, 2322792 subcases |
Add cases to the uniformity tests for vector function variables, including cases to test the uniformity rules for swizzle assignment as specified in: gpuweb/gpuweb#5268 All tests pass in Tint following this fix: https://dawn-review.googlesource.com/c/dawn/+/304176
8bf2231 to
9c25600
Compare
alan-baker
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cases to the uniformity tests for vector function variables, including cases to test the uniformity rules for swizzle assignment as specified in: gpuweb/gpuweb#5268
All tests pass in Tint following this fix:
https://dawn-review.googlesource.com/c/dawn/+/304176
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.