Merged
Conversation
kainino0x
approved these changes
Apr 23, 2026
Collaborator
|
LGTM % merge conflict |
* Test that resolving a timestamp twice produces the same result. * Test that slots that are never used resolve to zero.
9edd78b to
c33aa17
Compare
|
Results for build job (at c33aa17): +webgpu:api,operation,command_buffer,queries,timestampQuery:multi_resolve:* - 2 cases, 2 subcases (~1/case)
+webgpu:api,operation,command_buffer,queries,timestampQuery:unused_slots_are_zero:* - 2 cases, 2 subcases (~1/case)
-TOTAL: 281178 cases, 2322743 subcases
+TOTAL: 281182 cases, 2322747 subcases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the issue about
BigUint64Arrayis typescript 5.2.2 types I think. IIRC sometime between 5.2.2 and 5.9.3 fix it. They're now on 6.0.2 which I think broke a bunch of typedarray stuff.Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.