Skip to content

Change RangeError to OperationError in SetImmediatesTest#4646

Open
beicause wants to merge 1 commit into
gpuweb:mainfrom
beicause:set-immediate-test-operation-error
Open

Change RangeError to OperationError in SetImmediatesTest#4646
beicause wants to merge 1 commit into
gpuweb:mainfrom
beicause:set-immediate-test-operation-error

Conversation

@beicause
Copy link
Copy Markdown

@beicause beicause commented May 20, 2026

Issue: Fixes #4645


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x requested a review from shaoboyan091 May 20, 2026 16:55
Copy link
Copy Markdown
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but @shaoboyan091 it would be good to prepare a chromium fix so we don't lose test coverage for too long. Would you start on that and review this?

@github-actions
Copy link
Copy Markdown

Results for build job (at ecca31f):

 Test case/subcase counts did not change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setImmediates CTS expect RangeError but spec requires OperationError

2 participants