Add APIs to set viewport and scissor rect for render pass #135
Conversation
Richard-Yunchao
force-pushed
the
viewportAndScissorRect
branch
from
2652952 to
f085176
Compare
|
@Kangz , @kainino0x , @kvark , @RafaelCintron , @litherum , PTAL when you have time. |
design/sketch.webidl
Outdated
| // The default viewport is (0.0, 0.0, w, h, 0.0, 1.0), where w and h are the dimensions of back buffer | ||
| void setViewport(float x, float y, float, width, float height, float minDepth, float maxDepth); | ||
|
|
||
| // The default scissor rectangle is (0, 0, w, h), where w and h are the demensions of back buffer. |
There was a problem hiding this comment.
Done. Thanks for your review, @kvark
|
@Richard-Yunchao please squash the commits |
Richard-Yunchao
force-pushed
the
viewportAndScissorRect
branch
from
6c3ad56 to
43b31fd
Compare
Done. I remember that we can merge multiple commits into one commit when we merge the pr. So I didn't squash the commits before, @kvark . If you prefer to squash commits into one commit, I will do that in future. |
|
@Richard-Yunchao you are right. I just got used to bad automerge bots that don't know how to squash :) |
|
Can you take a look? @kvark . Shall we remove the comments for these two functions in this pr? |
|
In the future we may want support for multiple viewports (e.g. for VR). We should keep that future direction in mind. |
design/sketch.webidl
Outdated
| void setStencilReference(u32 reference); | ||
|
|
||
| // The default viewport is (0.0, 0.0, w, h, 0.0, 1.0), where w and h are the dimensions of back buffer | ||
| void setViewport(float x, float y, float, width, float height, float minDepth, float maxDepth); |
There was a problem hiding this comment.
Rouge comma (,) between float width. :)
There was a problem hiding this comment.
Fixed in prep for merge. Thanks for finding this!
|
Approved in the 2018-12-03 meeting with the typo fix @frzi mentioned. |
|
Aaaand @kainino0x fixed it, nice! |
Yes. I also simply discussed with a few guys about multiple viewports for WebVR several days ago. In addition, I added this statement into section at the investigation issue for Viewport and scissor tests. Thanks for your reminder, @litherum. |
6 participants
PTAL.
See the investigation about Viewport and Scissor Test at #120