Rename Binding to BindGroupBinding. #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more clear that this dictionary is meant to be used inside the BindGroupDescriptor and not BindGroupLayoutDescriptor.
|
uh, it honestly feels a bit too long now. Maybe we should keep it short and make sure the other one is longer, since it's not going to be used as much? |
|
I don't mind either way but I thought I'd raise this since I'm adding the structure in Dawn (as part of the "BindGroup descriptorization"). Note that in JS we wouldn't ever type the name of the structure. |
|
We already have BindGroupLayoutBinding (which this mirrors), so this is fine to me. |
|
No strong signal in the 2018-12-03 meeting, @jdashg what's your opinion? @kvark does the fact that JS doesn't need to mention the type change your opinion? |
|
This was discussed in the 10 Dec 2018 meeting |
|
Approved at that meeting. |
|
I always thought WebGPUBinding was super ambiguous, so I'm glad to see it clarified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more clear that this dictionary is meant to be used inside
the BindGroupDescriptor and not BindGroupLayoutDescriptor.