-
Notifications
You must be signed in to change notification settings - Fork 343
Allow unmasked adapter info fields to be requested individually. #2635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Mar 3, 2022
Co-authored-by: Kai Ninomiya <kainino@chromium.org>
kainino0x
approved these changes
Mar 5, 2022
kdashg
approved these changes
Mar 9, 2022
|
Thanks! |
WebGPU meeting minutes 2022-03-09
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Adapter identifiers proposal based on feedback from yesterday's call. Changes specifically include:
vendorwas not and it was assumed that"unknown"would be returned in cases where the UA did not wish to report the value. Given that Myles stated that Apple doesn't want to return the vendor by default I feel it's more important to give developers a clear sense of which values have not been reported than to always give them a string, regardless of it's accuracy.requestUnmaskedAdapterInfo().adapter.infoto no longer be[SameObject]and for it to update in-place whenrequestUnmaskedAdapterInfo()is called.I'd very much appreciate if Myles or another representative from Apple could give this a look and see if it addresses the changes that were requested.
Additionally, something I meant to ask on the call but forgot: Would Apple consider exposing any of these identifying values after user consent has been explicitly given in response to a
requestUnmaskedAdapterInfo()? I understand that the intent prior to that is to returnnullfor everything (which is allowed by this proposal).