Fix the use of generate.mjs on Windows#202
Merged
Merged
Conversation
Replace `bikeshed-to-ts` and `prettier` with bare command names (`bikeshed-to-ts`, `prettier`). The `./ prefix` is not recognized by `cmd.exe`, causing `npm run generate` to fail on Windows. Since `npm run` adds `.bin` to `PATH`, we can directly use bare command names on all platforms.
Jiawei-Shao
changed the title
generate.mjs on Windows
kainino0x
approved these changes
May 13, 2026
Collaborator
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
Thanks, I didn't realize they would be in the PATH. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
bikeshed-to-tsandprettierwith bare command names (bikeshed-to-ts,prettier). The./ prefixis not recognized bycmd.exe, causingnpm run generateto fail on Windows. Sincenpm runadds.bintoPATH, we can directly use bare command names on all platforms.