Conversation
2 tasks
2 tasks
gr2m
force-pushed
the
56-use-project-v2-nodes
branch
from
e34cef3 to
c622024
Compare
gr2m
changed the title
ProjectV2* APIs, add draft APIsProjectV2* APIs, add draft APIs
gr2m
force-pushed
the
56-use-project-v2-nodes
branch
from
32bdc45 to
2e4aa96
Compare
gr2m
commented
Aug 15, 2022
| // TODO: ideally we would retrieve a project item directly based on a content id | ||
| // and the project number, but GitHub's GraphQL Schema does not support that | ||
| // as of 2022-08-14. As a workaround, we load all project items and filter | ||
| // them by project number afterwards. |
Owner
Author
There was a problem hiding this comment.
| repositoryName: repositoryName, | ||
| number: issueOrPullRequestNumber, | ||
| }) | ||
| .catch(handleNotFoundGraphqlError); |
Owner
Author
There was a problem hiding this comment.
gr2m
changed the title
ProjectV2* APIs, add draft APIsProjectV2* APIs, add draft APIs, project.items.remove* APIs no return items if found
|
🎉 This PR is included in version 2.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
orgconstructor option has been replaced withownerin order to support user projectsBREAKING CHANGE: node IDs changed, even for the same projects/project items etc
BREAKING CHANGE:
project.item.remove*APIs now return the removed item, if it was found.Review Notes
Preview of new README (diff)
Preview of new CONTRIBUTING - (diff)
the
project.items.addDraft()API was addedAll
ProjectNext*GraphQL nodes have been replaced with theirProjectV2*notes throughout the code baseThe internal caching of project items have been removed. It's no longer necessary thanks to the better capabilities of the new
ProjectV2*nodes (before we needed it for the*ByContentIdand*ByContentRepositoryAndNumberAPIs). That means for projects with hundreds of items,projectwill become significantly faster and more reliable.Most of the changes are fixtures diffs, no need to review them. The rest is still quite a lot but the structure of the files didn't change much so it should be okay to review file-by-file.
closes #4
closes #5