Skip to content

Add test for calling .{write,end}(buffer, callback) #17

@gr2m

Description

@gr2m

Did you test when calling write, end et al. with a chunk and a callback

#3 (comment)

That's a minor thing, but given readable.setEncoding, the recorder is converting strings back to buffers presuming UTF-8(?).

My thinking here was to normalize the requestBodyChunks passed to the the record event listeners. I'm not worried about the performance overhead as this is a dev tool. Do you see any other problem? I will default encoding to utf-8 as part of #17

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions