Skip to content

Conversation

@spaenleh
Copy link
Member

@spaenleh spaenleh commented Sep 8, 2025

I removed the button and instead added an element at the end of the list if there is no exact match:

I also added the number of occurrences as a small chip in the option line.

Screen.Recording.2025-09-08.at.12.17.09.mov

close #1101

@spaenleh spaenleh requested a review from pyphilia September 8, 2025 10:20
@spaenleh spaenleh self-assigned this Sep 8, 2025
@spaenleh spaenleh added the fix A bug fix label Sep 8, 2025
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what about having the "Add" option a bit more different from the other options? Like having it in blue, italic, centered?

EDIT: add tests??

@spaenleh spaenleh force-pushed the 1101-fix-partial-tag branch 5 times, most recently from df517ce to d7ff85c Compare September 12, 2025 06:36
@spaenleh spaenleh force-pushed the 1101-fix-partial-tag branch from 52cadf6 to db7f713 Compare September 12, 2025 11:45
@sonarqubecloud
Copy link

@spaenleh spaenleh merged commit 3ca91d5 into main Sep 12, 2025
4 of 5 checks passed
@spaenleh spaenleh deleted the 1101-fix-partial-tag branch September 12, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot add partial tags

3 participants