Skip to content

fix: fix link related bugs in pages #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spaenleh merged 6 commits into from
Oct 1, 2025
Merged

fix: fix link related bugs in pages #1112

spaenleh merged 6 commits into from
Oct 1, 2025

Conversation

@pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Sep 15, 2025 •
edited
Loading

  • Toolbar is sticky
  • Remove white background for editor, to match with player view
  • Allow click on link (prevent redirection) to select the node and show the options. It is possible to visit the url through the link menu.
  • Hide firefox input number's arrow (font size)
  • Add a debug plugin (to add when on dev mode)
  • fix iframe reloading
Screen.Recording.2025-09-15.at.15.25.24.mov

sticky demo

Screen.Recording.2025-09-15.at.15.29.12.mov

@pyphilia pyphilia self-assigned this Sep 15, 2025
@pyphilia pyphilia changed the title fix: fix link related bugs fix: fix link related bugs in pages Sep 15, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 15, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pyphilia pyphilia marked this pull request as ready for review September 16, 2025 08:53
This was linked to issues Sep 16, 2025
Prevent page link-item iframe frequent reloading #1096
Closed
Allow easier click on page's link-item iframe #1097
Closed
@spaenleh spaenleh self-requested a review October 1, 2025 06:20
spaenleh
spaenleh approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@spaenleh spaenleh merged commit 8ec5b8d into main Oct 1, 2025
5 checks passed
@spaenleh spaenleh deleted the page-link-fixes branch October 1, 2025 12:20
@graasper graasper mentioned this pull request Oct 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels

v2.32.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow easier click on page's link-item iframe Prevent page link-item iframe frequent reloading

3 participants

@pyphilia @spaenleh