Skip to content

Conversation

@dawoodkhan82
Copy link
Collaborator

@dawoodkhan82 dawoodkhan82 commented Mar 31, 2025

Description

Demo with example image:
Screenshot 2025-04-02 at 6 36 51 PM

Demo with no example image:

Screenshot 2025-04-02 at 6 47 40 PM

Demo not running in SSR mode (no screenshot):
Screenshot 2025-04-02 at 6 46 34 PM

Twitter Card (Demo with example image):
Screenshot 2025-04-02 at 6 49 58 PM

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 31, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/8f16b053a01f13909dbe491818f259edb9f041f9/gradio-5.23.3-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@8f16b053a01f13909dbe491818f259edb9f041f9#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/8f16b053a01f13909dbe491818f259edb9f041f9/gradio-client-1.14.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/8f16b053a01f13909dbe491818f259edb9f041f9/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 31, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@self/app minor
@self/spa minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Meta tags for socials

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Apr 4, 2025

Ah so this won't directly work with Spaces right? Since the Gradio app is iframed and Spaces has their own meta tag? e.g. https://socialsharepreview.com/?url=https://huggingface.co/spaces/abidlabs/test-og

@abidlabs
Copy link
Member

abidlabs commented Apr 4, 2025

I chatted with @dawoodkhan82 about this:

  • not sure if the screenshot is a good idea because the screenshots are hard to parse and won't work for Spaces anyways as I mentioned above
  • Instead, I think we should do the following:
  1. Fix the default meta tags and image so that they aren't broken (in this PR)
  2. Allow users to set their own meta tags (probably also in this PR)
  3. Modify the meta tag in Spaces for a nicer preview similar to GH social cards (separately)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants