-
Notifications
You must be signed in to change notification settings - Fork 492
Add component metrics to /metrics endpoint #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I was wondering if instead to have an specific metric per component we could have generic metrics (accessed, errors, etc) with a label as component name. That would give us the ability to easily add metrics to new components without having to create new metrics per component, like in this ongoing PR |
|
There is probably room for some generic cases: |
rfratto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice!
I tested it out with a few reloads after removing / adding components and everything looks clean.
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
PR Description
Add support for passing prometheus register to components and wrapping them with the component id. I used
component_idsince I thoughtidmight be used elsewhere since it is so generic. Adds ready endpoint that is triggered from the initial load/reload.Which issue(s) this PR fixes
Closes #1938
Notes to the Reviewer
PR Checklist