database_observability: add collector to get enabled performance_schema.setup_consumers #3110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
💻 Deploy preview available: |
fridgepoet
changed the title
fridgepoet
commented
Mar 31, 2025
internal/component/database_observability/mysql/collector/setup_consumers.go
Show resolved
Hide resolved
fridgepoet
commented
Mar 31, 2025
docs/sources/reference/components/database_observability/database_observability.mysql.md
Show resolved
Hide resolved
fridgepoet
requested review from
a team,
clayton-cornell,
cristiangreco and
matthewnolf
as code owners
docs/sources/reference/components/database_observability/database_observability.mysql.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
…ase_observability.mysql.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
|
|
clayton-cornell
approved these changes
Apr 4, 2025
Contributor
clayton-cornell
left a comment
clayton-cornell
left a comment
There was a problem hiding this comment.
Approving for docs.
matthewnolf
reviewed
Apr 9, 2025
internal/component/database_observability/mysql/collector/setup_consumers.go
Outdated
Show resolved
Hide resolved
internal/component/database_observability/mysql/collector/setup_consumers.go
Show resolved
Hide resolved
internal/component/database_observability/mysql/collector/setup_consumers.go
Outdated
Show resolved
Hide resolved
internal/component/database_observability/mysql/collector/setup_consumers.go
Outdated
Show resolved
Hide resolved
cristiangreco
requested changes
Apr 9, 2025
internal/component/database_observability/mysql/collector/setup_consumers.go
Outdated
Show resolved
Hide resolved
internal/component/database_observability/mysql/collector/setup_consumers.go
Outdated
Show resolved
Hide resolved
internal/component/database_observability/mysql/collector/setup_consumers.go
Show resolved
Hide resolved
4 tasks
Contributor
Author
|
Added a separate collect interval in the config (couldn't think of a very good name), please take a look. |
docs/sources/reference/components/database_observability/database_observability.mysql.md
Show resolved
Hide resolved
…ase_observability.mysql.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
internal/component/database_observability/mysql/collector/setup_consumers.go
Outdated
Show resolved
Hide resolved
cristiangreco
approved these changes
Apr 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR:
performance_schema.setup_consumersto a new SetupConsumers collectorWhich issue(s) this PR fixes
Fixes https://github.com/grafana/grafana-dbo11y-app/issues/634
Notes to the Reviewer
Here's a silly panel visualizing the resulting metrics: (1 is enabled, 0 is disabled)
PR Checklist