database_observability: add support for expressions in index definition #3132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiangreco
force-pushed
the
cristian/dbo11y-table-index-expr
branch
from
585c193 to
024fb8b
Compare
cristiangreco
requested review from
a team,
fridgepoet and
matthewnolf
as code owners
|
|
fridgepoet
reviewed
Apr 4, 2025
|
|
||
| if columnName.Valid { | ||
| lastIndex.Columns = append(lastIndex.Columns, columnName.String) | ||
| } else if expression.Valid { |
Contributor
There was a problem hiding this comment.
What if you have both a columnName and expression?
Contributor
Author
There was a problem hiding this comment.
Docs says they are mutually exclusive, and there's no syntax in current mysql versions to create an index with both a column and an expression. We could add support for such a possible edge case, but I'm thinking it might be better to do it when/if we find anything odd (just to avoid supporting all possible edge cases as it makes the code harder to follow).
cristiangreco
force-pushed
the
cristian/dbo11y-table-index-expr
branch
from
024fb8b to
7d8c2a6
Compare
Fetch index expresssion, if present, and store it in the index spec.
cristiangreco
force-pushed
the
cristian/dbo11y-table-index-expr
branch
from
7d8c2a6 to
ed82078
Compare
matthewnolf
approved these changes
Apr 9, 2025
matthewnolf
pushed a commit
that referenced
this pull request
Apr 9, 2025
…on (#3132) Fetch index expresssion, if present, and store it in the index spec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fetch index expression, if present, and store it in the index spec.
Which issue(s) this PR fixes
n.a.
Notes to the Reviewer
PR Checklist