This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Added playbook for CortexAllocatingTooMuchMemory #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Jul 2, 2021
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
LGTM, nice improvements.
cortex-mixin/alerts/alerts.libsonnet
Outdated
| annotations: { | ||
| message: ||| | ||
| High QPS for ingesters, add more ingesters. | ||
| Ingesters in {{ $labels.namespace }} have an high samples/sec rate. |
Contributor
There was a problem hiding this comment.
Alternative: Ingesters in {{ $labels.namespace }} ingest too many samples per second.
cortex-mixin/docs/playbooks.md
Outdated
| - Cortex ingesters are a stateful service | ||
| - Having 2+ ingesters `OOMKilled` may cause a cluster outage | ||
| - Ingester memory baseline usage is primarily influenced by memory allocated by the process (mostly go heap) and mmap-ed files (used by TSDB) | ||
| - Ingester memory short spikes are primarily influenced by queries |
Contributor
There was a problem hiding this comment.
Also when cutting new blocks.
cortex-mixin/docs/playbooks.md
Outdated
| - Having 2+ ingesters `OOMKilled` may cause a cluster outage | ||
| - Ingester memory baseline usage is primarily influenced by memory allocated by the process (mostly go heap) and mmap-ed files (used by TSDB) | ||
| - Ingester memory short spikes are primarily influenced by queries | ||
| - A pod gets `OOMKilled` once it's working set memory reaches the configured limit, so it's important to prevent ingesters memory utilization (working set memory) from getting close to the limit (we need to keep at least 30% room for spikes due to queries) |
Contributor
There was a problem hiding this comment.
"it's working set" -> "its working set"
cortex-mixin/docs/playbooks.md
Outdated
| ``` | ||
| kubectl -n <namespace> delete pod ingester-XXX | ||
| ``` | ||
| - Restarting an ingester typically reduces the memory allocated by mmap-ed files. Such memory could be reallocated again, but may let you gain more time while working on a longer term solution |
Contributor
There was a problem hiding this comment.
Suggested change
| - Restarting an ingester typically reduces the memory allocated by mmap-ed files. Such memory could be reallocated again, but may let you gain more time while working on a longer term solution | |
| - Restarting an ingester typically reduces the memory allocated by mmap-ed files. After the restart, ingester may allocate this memory again over time, but it may give more time while working on a longer term solution |
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Collaborator
Author
|
Thanks @pstibrany for your valuable feedback! Applied all changes. |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…or-CortexAllocatingTooMuchMemory Added playbook for CortexAllocatingTooMuchMemory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added playbook for CortexAllocatingTooMuchMemory. I've also changed a bit the CortexAllocatingTooMuchMemory and CortexProvisioningTooManyWrites messages.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]