feat: handle line-number anchors and issue comments globally#56
Merged
zeitlinger merged 1 commit intomainfrom Feb 23, 2026
Merged
feat: handle line-number anchors and issue comments globally#56zeitlinger merged 1 commit intomainfrom
zeitlinger merged 1 commit intomainfrom
Conversation
Add global GitHub URL handling that applies to ALL repositories, not just the current one: - Line-number anchors (#L123, #L10-L20) on any GitHub /blob/ URL are stripped so the file is still checked but the JS-rendered fragment is skipped - Issue comment anchors (#issuecomment-*) are excluded entirely as they are JS-rendered This means consuming repos no longer need to add these exclusions to their lychee.toml configs. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the link checking script to handle GitHub-specific URL patterns globally, eliminating the need for consuming repositories to configure these exclusions in their own lychee.toml files. The changes centralize handling of line-number anchors and issue comment anchors for any GitHub repository.
Changes:
- Added global remap rule to strip line-number anchors (
#L123,#L10-L20) from all GitHub/blob/URLs - Added global exclusion for issue comment anchors (
#issuecomment-*) - Removed the workaround remap from flint's own
lychee.toml(now handled by script)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tasks/lint/links.sh | Added build_global_github_args() function to generate global remap and exclude rules for GitHub URLs |
| tests/test-links.md | Added test cases for external repository line-number anchors and issue comment anchors |
| README.md | Documented the new global GitHub URL handling behavior |
| .github/config/lychee.toml | Removed the static remap rule (now handled dynamically by the script) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
zeitlinger
added a commit
that referenced
this pull request
Feb 23, 2026
## Summary Fixes the lint failure in #41 (release-please PR). CLI `--exclude` overrides (rather than merges with) config file excludes in lychee. The `--exclude` added in #56 for `#issuecomment-` URLs caused the config file's `exclude` patterns (like the `compare/` URL exclusion) to be ignored. Fix: switch to `--remap` which strips the `#issuecomment-` fragment while still checking the issue/PR page itself. ## Test plan - [ ] CI passes (the release-please PR #41 should also pass after this merges) Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
pushed a commit
that referenced
this pull request
Feb 23, 2026
🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.0...v0.7.0) (2026-02-23) ### Features * handle line-number anchors and issue comments globally ([#56](#56)) ([cf751df](cf751df)) ### Bug Fixes * **release-please:** fix footer not appearing on release PRs ([#40](#40)) ([d7a55e4](d7a55e4)) * use remap instead of exclude for issue comment anchors ([#58](#58)) ([656f355](656f355)) --- > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#L123,#L10-L20) from ALL GitHub/blob/URLs (any repo), so the file is still checked but the JS-rendered fragment is skipped#issuecomment-*) globally — these are JS-rendered and cannot be verified by lycheelychee#1729remap workaround from flint's ownlychee.toml(now handled by the script)This means consuming repos no longer need to add these exclusions to their
lychee.tomlconfigs. Discovered while adopting flint in opentelemetry-java-instrumentation#16270.Test plan
tests/test-links.md)okhttp build.gradle#L144-L153) passes