Skip to content

test: improve test workflow to reduce boilerplate#104

Merged
abannachGrafana merged 5 commits intomainfrom
adam.bannach/dependabot-update
May 6, 2025
Merged

test: improve test workflow to reduce boilerplate#104
abannachGrafana merged 5 commits intomainfrom
adam.bannach/dependabot-update

Conversation

@abannachGrafana
Copy link
Copy Markdown
Contributor

  • test: update test workflow to check for fork as prerequisite
  • chore(zizmor): fix zizmor finding and comment on template injection of action
  • test: update fork check to include push event to main
  • test: remove ref and incorrect event methods
  • chore: remove unused workflow

@abannachGrafana abannachGrafana requested review from a team and Copilot May 6, 2025 14:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve the test workflow by reducing boilerplate and ensuring that tests are only run on non-forked repositories. Key changes include:

  • Adding a new "check-not-fork" job to determine if the action is triggered from a fork.
  • Updating various test jobs to depend on the "check-not-fork" job.
  • Modifying a comment in action.yml regarding template injection via environment variables and updating permissions in the automerge-dependabot workflow.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
action.yml Updated comment addressing template injection and env var handling.
.github/workflows/test.yml Added fork check job and linked it as a dependency to multiple test jobs.
.github/workflows/automerge-dependabot.yml Moved permissions under the job definition to align with intended access.
Files not reviewed (1)
  • .github/workflows/ci.yml: Language not supported

Comment thread action.yml
Comment thread .github/workflows/test.yml
@abannachGrafana abannachGrafana merged commit 702c057 into main May 6, 2025
21 checks passed
@abannachGrafana abannachGrafana deleted the adam.bannach/dependabot-update branch May 6, 2025 15:28
This was referenced May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants