test: improve test workflow to reduce boilerplate#104
Merged
abannachGrafana merged 5 commits intomainfrom May 6, 2025
Merged
Conversation
Contributor
abannachGrafana
commented
May 6, 2025
- test: update test workflow to check for fork as prerequisite
- chore(zizmor): fix zizmor finding and comment on template injection of action
- test: update fork check to include push event to main
- test: remove ref and incorrect event methods
- chore: remove unused workflow
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve the test workflow by reducing boilerplate and ensuring that tests are only run on non-forked repositories. Key changes include:
- Adding a new "check-not-fork" job to determine if the action is triggered from a fork.
- Updating various test jobs to depend on the "check-not-fork" job.
- Modifying a comment in action.yml regarding template injection via environment variables and updating permissions in the automerge-dependabot workflow.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| action.yml | Updated comment addressing template injection and env var handling. |
| .github/workflows/test.yml | Added fork check job and linked it as a dependency to multiple test jobs. |
| .github/workflows/automerge-dependabot.yml | Moved permissions under the job definition to align with intended access. |
Files not reviewed (1)
- .github/workflows/ci.yml: Language not supported
Johngeorgesample
approved these changes
May 6, 2025
This was referenced May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.