Feat!: Convert action to use graphql mutation #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abannachGrafana
changed the title
abannachGrafana
requested review from
L2D2Grafana,
darrenjaneczek and
xiyu95
xiyu95
reviewed
Feb 10, 2025
| @@ -1,46 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
So package.json is being deleted. How does the project get its dependencies?
There was a problem hiding this comment.
So this is now just a composite action which doesn't pull any dependencies at all. Just runs bash commands in action.yml
abannachGrafana
commented
Feb 10, 2025
|
|
||
| - package-ecosystem: npm # This is the correct value for yarn https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem | ||
| directory: / | ||
| - package-ecosystem: 'npm' |
There was a problem hiding this comment.
could probably delete this, but if we ever include package.json again in the future we won't have to change dependabot settings
xiyu95
approved these changes
Feb 10, 2025
abannachGrafana
changed the title
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If committing to a fast paced repo (lots of commits) there was a frequent failure that can happen because the commit oid being committed to is not the latest.
Description of fix
By using
git ls-remote --heads origin <ref>we fetch the latest oid from the remote repository without having to pull all commits locally. This in theory should minimize failures since oid fetching occurs right before commit and with less time wasted pulling commits it should succeed more often than not.Converting to a Graphql api call instead of typescript with normal api calls simplifies the action by not having to create a tree object while committing. Reducing the chance for errors since we are only passing file contents along instead of tree structures.