Enable PDC on Github Datasource #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transport is overridden for access token client
|
|
zoltanbedi
requested changes
Nov 10, 2025
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
…tasource into jck/enable-pdc
zoltanbedi
requested changes
Nov 12, 2025
Member
|
Also Santiago had a good point to add a line to the docs that PDC is supported. |
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PDC on the GitHub datasource:
I tested using: https://wiki.grafana-ops.net/w/index.php/Engineering/Grafana/Data_Sources/API_servers/Testing_datasources_with_PDC_Locally.
Confirmed that after enabling PDC, and the secure socks proxy toggle, I could see logs coming from the Agent. Similarly when I turned the agent off, I could see queries begin to fail.
Fixes #120