This repository was archived by the owner on Jan 15, 2024. It is now read-only.
🔧 Add required elements for GitHub Datasource #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| httpHeaderNames []string | ||
|
|
||
| // Used by Github | ||
| GitHubURL string `json:"githubUrl,omitempty"` |
Contributor
There was a problem hiding this comment.
Nit: hub shouldn't be capitalized
Suggested change
| GitHubURL string `json:"githubUrl,omitempty"` | |
| GithubURL string `json:"githubUrl,omitempty"` |
Contributor
There was a problem hiding this comment.
Nvm, I just checked their page title and it is capitalized there 🤦
julienduchesne
approved these changes
Jan 17, 2022
Contributor
julienduchesne
left a comment
julienduchesne
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution!
Contributor
Author
|
Fantastic, thank you @julienduchesne. I will now work on the terraform-provider-grafana repository as per the conversation here. |
Contributor
|
I've just pushed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in relation to this pull request.