Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

🔧 Add required elements for GitHub Datasource #50

Merged
merged 3 commits into from
Jan 17, 2022
Merged

🔧 Add required elements for GitHub Datasource #50

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71f5278
:wrench: Add GitHubUrl to JSON struct
Gary-H9 Jan 17, 2022
d75860c
:wrench: Add AccessToken to SecureJSONData struct
Gary-H9 Jan 17, 2022
bd9579e
:recycle: Update style of GitHubUrl to GitHubURL
Gary-H9 Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions datasource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ type JSONData struct {
TLSSkipVerify bool `json:"tlsSkipVerify,omitempty"`
httpHeaderNames []string

// Used by Github
GitHubURL string `json:"githubUrl,omitempty"`
Copy link
Contributor

@julienduchesne julienduchesne Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: hub shouldn't be capitalized

Suggested change
GitHubURL string `json:"githubUrl,omitempty"`
GithubURL string `json:"githubUrl,omitempty"`

Copy link
Contributor

@julienduchesne julienduchesne Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, I just checked their page title and it is capitalized there 🤦


// Used by Graphite
GraphiteVersion string `json:"graphiteVersion,omitempty"`

Expand Down Expand Up @@ -209,6 +212,9 @@ type SecureJSONData struct {
// Used by Prometheus and Elasticsearch
SigV4AccessKey string `json:"sigV4AccessKey,omitempty"`
SigV4SecretKey string `json:"sigV4SecretKey,omitempty"`

// Used by GitHub
AccessToken string `json:"accessToken,omitempty"`
}

// Required to avoid recursion during unmarshal
Expand Down