feat: OracleDB logs expression update #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caleb-Hurshman
approved these changes
Aug 12, 2024
algchoo
force-pushed
the
feat/oracledb-logs-expression
branch
from
5a60ca8 to
de111fa
Compare
Dasomeone
approved these changes
Aug 13, 2024
algchoo
added a commit
to observIQ/jsonnet-libs
that referenced
this pull request
Aug 13, 2024
* update log expression to match on filename or log_type labels * update log_type to match on oracledb-alert * revert oracledb-alert to oracledb for log_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The expression for logs required a label called
filenamewith a value that equates to an alert log file path. Ink8sthis file is not something that is read from. Requiring an arbitrary label with a value to a path that does not exist is potentially confusing.The solution, alter the expression to accept
filename=pathToAlertLogsorlog_type="oracledb"and in thek8splugin snippets for collecting logs, we addlog_type="oracledb"and users can just copy/paste the config without potentially becoming confused.Important note:
The OracleDB container logs are more than just logs from the alert file and there's not a clear way to filter on just the ones we'd get from the alert log.
Changes