Fix issue where qpsPanel shows an empty series name for gRPC requests with an underscore in their status code
#1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with an underscore in their status code
tcp13equals2
approved these changes
Oct 27, 2025
1 task
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Oct 28, 2025
#### What this PR does This PR brings in the fix from grafana/jsonnet-libs#1519. #### Which issue(s) this PR fixes or relates to (none) #### Checklist - [n/a] Tests updated. - [n/a] Documentation added. - [x] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [n/a] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features.
Contributor
|
Why do we restrict any status codes there? Eg suppose someone puts CLOUD9, that will get transformed to |
Contributor
Author
The main purpose of the regex is to differentiate between the HTTP case (numeric status code) and gRPC status code (string like We could extend the pattern to support other strings as well, but the gRPC status codes as they currently stand only include A-Z and underscores. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, requests that return
NOT_FOUNDorFAILED_PRECONDITIONwould be grouped together and show an empty series name.