Skip to content

feat(ncHistogramApplyTemplate): simple templating of native/classic q… #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

feat(ncHistogramApplyTemplate): simple templating of native/classic q… #1555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions mixin-utils/test/test_native-classic-histogram.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,3 +228,13 @@ test.new(std.thisFile)
},
)
)
+ test.case.new(
name='simple templating',
test=test.expect.eq(
actual=utils.ncHistogramApplyTemplate('label_replace(%s, "x", "$1", "y", "(.*)")', { classic: 'classic_query', native: 'native_query' }),
expected={
classic: 'label_replace(classic_query, "x", "$1", "y", "(.*)")',
native: 'label_replace(native_query, "x", "$1", "y", "(.*)")',
}
)
)
10 changes: 10 additions & 0 deletions mixin-utils/utils.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,16 @@ local g = import 'grafana-builder/grafana.libsonnet';
},
},

// ncHistogramApplyTemplate (native classic histogram template applier)
// Takes a template like 'label_replace(%s, "x", "$1", "y", ".*")'
// with a single substitution and applies to both the classic and native
// histogram query.
ncHistogramApplyTemplate(template, query):: {
assert $.isNativeClassicQuery(query),
native: template % query.native,
classic: template % query.classic,
},

// ncHistogramComment (native classic histogram comment) helps attach
// comments to the query and also keep multiline strings where applicable.
ncHistogramComment(query, comment):: {
Expand Down
Loading