browser: Fix TestNavigationSpanCreation
#5378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR made this race condition apparent, so instead of adding another PR to fix it, I've added a small commit here to fix the issue.
6 tasks
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
changed the title
TestNavigationSpanCreationTestNavigationSpanCreation
inancgumus
changed the title
TestNavigationSpanCreationTestNavigationSpanCreation
AgnesToulet
approved these changes
Nov 10, 2025
joanlopez
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes
TestNavigationSpanCreationWhy?
Without this, most CI jobs fail all the time.
This error is a navigational issue that occurs when the code (i.e.,
window.history.back) executes on Chrome, causing the page to navigate back before the CDP command (eval) completes, resulting in unnecessary noise. That's not a real error, but rather a sentinel message, similar to Go'sio.EOF. It's expected and should be handled that way, as Chrome runs the code but terminates the CDP command due to cross-navigation.This error previously occurred on CI, but it has become more apparent now due to our involved browser tests.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.