-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix(helm): ensure global.extraEnv and global.extraEnvFrom applied to all resources consistently #16828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are some other areas in the read module that need fixing (I'm mainly referencing the |
|
Tagging @bentonam and @poyzannur for review as original authors of the global extraEnv changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siegenthalerroger thank you for catching this and submitting the changes! The changes LGTM, I do not have the ability to merge, I will defer to @poyzannur for final approval and merging of the changes. If you could resolve the merge conflict for production/helm/loki/CHANGELOG.md that would be appreciated
…all resources consistently
c8e9a98 to
ec53c6d
Compare
|
@siegenthalerroger could you please address failing CI tests |
What this PR does / why we need it:
The
global.extraEnvandglobal.extraEnvFromvalues introduced in chart 6.27.0 where not included for all declared resources and in some cases weren't applied correctly.Similar PRs:
statefulset-backend.yamlextraEnvFrom#16708Which issue(s) this PR fixes:
Fixes #16380
Fixes #16565
Fixes #16683
Fixes #16713
Fixes #16713
Fixes #17284
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR