Skip to content

chore: rename consumption lag variable#16878

Merged
grobinson-grafana merged 1 commit intomainfrom
grobinson/rename-metric-variable
Mar 24, 2025
Merged

chore: rename consumption lag variable#16878
grobinson-grafana merged 1 commit intomainfrom
grobinson/rename-metric-variable

Conversation

@grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 24, 2025

What this PR does / why we need it:

This renames the variable for two reasons:

  1. It matches the metric name
  2. I want to add a second metric that tracks consumption lag offset, not just seconds

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 24, 2025 16:53
@grobinson-grafana grobinson-grafana force-pushed the grobinson/rename-metric-variable branch from be78bc8 to e663a1a Compare March 24, 2025 16:54
@grobinson-grafana grobinson-grafana enabled auto-merge (squash) March 24, 2025 17:10
@grobinson-grafana grobinson-grafana merged commit c0f795e into main Mar 24, 2025
62 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/rename-metric-variable branch March 24, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants