Skip to content

chore: revert changing histogram to gauge#16889

Merged
grobinson-grafana merged 1 commit intomainfrom
grobinson/change-metric-back-to-histogram
Mar 24, 2025
Merged

chore: revert changing histogram to gauge#16889
grobinson-grafana merged 1 commit intomainfrom
grobinson/change-metric-back-to-histogram

Conversation

@grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 24, 2025

What this PR does / why we need it:

This pull request reverts #16864. It has a number of problems such as the gauge still being omitted when the phase changes. I would like to revert it and then explore it further before keeping it as a gauge.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 24, 2025 21:24
@grobinson-grafana grobinson-grafana force-pushed the grobinson/change-metric-back-to-histogram branch from 7376e45 to 85bf83d Compare March 24, 2025 21:28
@grobinson-grafana grobinson-grafana merged commit 5b232db into main Mar 24, 2025
61 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/change-metric-back-to-histogram branch March 24, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants