fix: pattern ingester pushes detected level as structured metadata#16924
Merged
trevorwhitney merged 2 commits intomainfrom Mar 27, 2025
Merged
fix: pattern ingester pushes detected level as structured metadata#16924trevorwhitney merged 2 commits intomainfrom
trevorwhitney merged 2 commits intomainfrom
Conversation
6 tasks
6 tasks
This was referenced May 19, 2025
This was referenced May 26, 2025
This was referenced Jun 24, 2025
This was referenced Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this change, the pattern ingester pushed aggregated metrics as an indexed label. This is unnecessary as drilldown assumes all detected levels will be in structured metadata (which the indexed label will be stored as during level detection in the distributor). This is also problematic, as levels used for aggregated metrics will show up in the
/label/level/valuesendpoint. For users who enforce policies around level, like all caps, then the values added by aggregated metric will be confusing. Finally, indexing the level also increases the cardinality of these streams unecessarily.This PR changes the pattern ingester to send the detected level as structured metadata, which fixes all the problems listed above.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR