Skip to content

fix: Allow dashes in storage_prefix config#16934

Merged
ashwanthgoli merged 1 commit intografana:mainfrom
matthewhudsonedb:main
Mar 27, 2025
Merged

fix: Allow dashes in storage_prefix config#16934
ashwanthgoli merged 1 commit intografana:mainfrom
matthewhudsonedb:main

Conversation

@matthewhudsonedb
Copy link
Contributor

What this PR does / why we need it:
Allow dashes in storage_prefix config of thanos object storage config so we have parity with previous object_prefix config.

Which issue(s) this PR fixes:
Fixes #16931

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@matthewhudsonedb matthewhudsonedb requested a review from a team as a code owner March 27, 2025 10:48
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 27, 2025
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ashwanthgoli ashwanthgoli merged commit c01d9c7 into grafana:main Mar 27, 2025
63 checks passed
@winggundamth
Copy link

What version will this fix be merged into?

@JStickler
Copy link
Contributor

@winggundamth It really depends on what the next release ends up being. We try to have a major/minor release once a quarter, but have patch releases when needed to patch CVEs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to migrate to thanos object storage configuration due to storage prefix contains invalid characters

4 participants