-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat(helm): Enable rules sidecar for the ruler pods #17231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Enable rules sidecar for the ruler pods #17231
Conversation
|
Thanks for adding this @madaraszg-tulip! Shall bring up at the Loki engineering call today |
|
@madaraszg-tulip would you mind fixing the failed test I belive it just needs a docs update: |
f4afaf0 to
a51297a
Compare
poyzannur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for the contribution
Could you please include a changelog entry?
Sure I can, I didn't think I'd need to do it because the CONTRIBUTING doc says the following: So what's the procedure to provide a changelog entry? CHANGELOG.md seems to be autogenerated |
|
There is a separate CHANGELOG for the Loki Helm chart. https://github.com/grafana/loki/blob/main/production/helm/loki/CHANGELOG.md |
Thanks, updated |
|
Hello, when will this change be released? |
What this PR does / why we need it:
Currently there is no way to deploy loki rules in an automated way when running in distributed mode. The recommended way is to deploy the rules using lokitool to the object storage, however there is no automation provided for that in the helm chart.
Simple scalable mode provided a rules sidecar to the backend pods which automatically imported rules from kubernetes configmaps and secrets. Implement the same sidecar for the ruler pods, gated by the ruler.sidecar switch which defaults to false.
Which issue(s) this PR fixes:
Fixes #16529
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR