Skip to content

Conversation

@madaraszg-tulip
Copy link
Contributor

@madaraszg-tulip madaraszg-tulip commented Apr 15, 2025

What this PR does / why we need it:

Currently there is no way to deploy loki rules in an automated way when running in distributed mode. The recommended way is to deploy the rules using lokitool to the object storage, however there is no automation provided for that in the helm chart.

Simple scalable mode provided a rules sidecar to the backend pods which automatically imported rules from kubernetes configmaps and secrets. Implement the same sidecar for the ruler pods, gated by the ruler.sidecar switch which defaults to false.

Which issue(s) this PR fixes:
Fixes #16529

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@madaraszg-tulip madaraszg-tulip requested a review from a team as a code owner April 15, 2025 09:49
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2025

CLA assistant check
All committers have signed the CLA.

@Jayclifford345
Copy link
Contributor

Thanks for adding this @madaraszg-tulip! Shall bring up at the Loki engineering call today

@Jayclifford345
Copy link
Contributor

@madaraszg-tulip would you mind fixing the failed test I belive it just needs a docs update: helm-docs

@madaraszg-tulip madaraszg-tulip force-pushed the madaraszg.ruler-sidecar branch from f4afaf0 to a51297a Compare April 15, 2025 10:22
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 15, 2025
Copy link
Contributor

@poyzannur poyzannur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the contribution
Could you please include a changelog entry?

@madaraszg-tulip
Copy link
Contributor Author

Hi there, thanks for the contribution Could you please include a changelog entry?

Sure I can, I didn't think I'd need to do it because the CONTRIBUTING doc says the following:
The PR title will appear in a changelog, so help other people understand what your change will be.

So what's the procedure to provide a changelog entry? CHANGELOG.md seems to be autogenerated

@JStickler
Copy link
Contributor

JStickler commented Apr 22, 2025

There is a separate CHANGELOG for the Loki Helm chart.

https://github.com/grafana/loki/blob/main/production/helm/loki/CHANGELOG.md

@madaraszg-tulip
Copy link
Contributor Author

There is a separate CHANGELOG for the Loki Helm chart.

https://github.com/grafana/loki/blob/main/production/helm/loki/CHANGELOG.md

Thanks, updated

@poyzannur poyzannur merged commit 2c5ad02 into grafana:main Apr 25, 2025
71 checks passed
@ncorreia
Copy link

Hello, when will this change be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart fails to create the sidecar in the ruler pod in microservices (distributed) mode

6 participants