chore: separate out tests for GetPartitionConsumers #17288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit separates out the tests for GetPartitionConsumers from GetStreamUsage, and adds separate tests to assert the expected behavior of GetPartitionConsumers and the expected behavior of the cache.
| } | ||
|
|
||
| func (g *RingStreamUsageGatherer) getPartitionConsumers(ctx context.Context, rs ring.ReplicationSet) (map[int32]string, error) { | ||
| func (g *RingStreamUsageGatherer) getPartitionConsumers(ctx context.Context, instances []ring.InstanceDesc) (map[int32]string, error) { |
Contributor
Author
There was a problem hiding this comment.
We will using this for zone-awareness.
| } | ||
| } | ||
|
|
||
| func TestRingStreamUsageGatherer_GetPartitionConsumers_CacheHitsAndMisses(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
Splitting out this test will make it easier to test zone awareness.
| const numPartitions = 2 // Using 2 partitions for simplicity in tests | ||
| const cacheTTL = 1 * time.Second | ||
|
|
||
| func TestRingStreamUsageGatherer_GetPartitionConsumers(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
Changed to test GetPartitionConsumers, as that is where the cache is used.
grobinson-grafana
force-pushed
the
grobinson/separate-tests-for-get-partition-consumers
branch
from
c5fd1d8 to
b58fbcb
Compare
6 tasks
periklis
approved these changes
Apr 18, 2025
grobinson-grafana
deleted the
grobinson/separate-tests-for-get-partition-consumers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit separates out the tests for GetPartitionConsumers from GetStreamUsage, and adds separate tests to assert the expected behavior of GetPartitionConsumers and the expected behavior of the cache.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR