feat(dataobj executor): project node #17312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return failureState(err) | ||
| } | ||
|
|
||
| batch, err := input.Value() |
Contributor
There was a problem hiding this comment.
do not have a strong opinion about this. but with this API design, the same err is returned twice once with input.Read() and then again with input.Value()
Contributor
Author
There was a problem hiding this comment.
Can you explain a bit more? The first error comes from the child Pipeline (via Read()) and the second from the same pipeline via Value(). I don't think we can make assumptions about these being the same, although it's possible we could revisit the Pipeline interface, but that's beyond the scope of this PR
owen-d
force-pushed
the
dataobj-executor-project-node
branch
from
d51ea72 to
9f5f50c
Compare
This was referenced Jun 24, 2025
This was referenced Jul 7, 2025
This was referenced Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on / followup to #17311
Implement Projection Pipeline in Engine Executor
Changes
This PR adds projection support to the Loki query engine executor, allowing queries to select specific columns from record batches. Key changes include:
NewProjectPipelinefunction for creating projection pipelinesexecuteProjectionmethodevaluatorfield to theContextstruct for expression evaluationTest Coverage
The implementation includes thorough tests that verify: