feat(helm): Add block_builder config to helm chart
#17451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
reviewed
Jun 30, 2025
Contributor
jkroepke
left a comment
jkroepke
left a comment
There was a problem hiding this comment.
Hi, would you mind running
make helm-docs
so it passes the lint test.
Contributor
Author
|
@jkroepke |
jkroepke
reviewed
Jul 4, 2025
Contributor
jkroepke
left a comment
jkroepke
left a comment
There was a problem hiding this comment.
looks odd to me as well.
Apply suggestions from code review Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: WesselAtWork <115667066+WesselAtWork@users.noreply.github.com>
jkroepke
reviewed
Jul 4, 2025
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: WesselAtWork <115667066+WesselAtWork@users.noreply.github.com>
Contributor
Author
|
Should I squash these changes or is this fine? |
jkroepke
reviewed
Jul 7, 2025
Contributor
jkroepke
left a comment
jkroepke
left a comment
There was a problem hiding this comment.
LGTM.
From my point of view squad for 3 commits is not nessesary.
Jayclifford345
approved these changes
Jul 8, 2025
6 tasks
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
block_builderoption to the default config in the loki helm chartSpecial notes for your reviewer:
What is the relation with the same configuration options in the
ingesterconfig?Should they be related?
How do I increment the helm version?
Is that something I need to worry about.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md