feat: add kafkav2 client #17610
Closed
feat: add kafkav2 client #17610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/kafka-client-v2
branch
5 times, most recently
from
165f5e8 to
217a049
Compare
This commit adds a new kafka client called clientv2. I will replace existing use of the current package over a number of subsequent PRs to make it easier to review and test changes in isolation. The motivation for this new package is that it was hard to create a *kgo.Client that could both produce and consume records. To fix this, the v2 client separates creating the client from creating the options, enabling the use of clients that produce, consume, and do both.
grobinson-grafana
force-pushed
the
grobinson/kafka-client-v2
branch
from
ca8844d to
041c894
Compare
grobinson-grafana
force-pushed
the
grobinson/kafka-client-v2
branch
from
041c894 to
28533f6
Compare
|
|
||
| // TODO(grobinson): These will be removed when we figure out how to support | ||
| // different addresses for read and write clients in kafka.Config, | ||
| KafkaReadAddress string `yaml:"kafka_read_address"` |
Contributor
Author
There was a problem hiding this comment.
This is a quick fix to support different addresses for read and write agents. I tried having separate configs, but it creates other problems. I need time to think about the correct solution here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit adds a new kafka client called
clientv2. I will replace existing use of the current package over a number of subsequent PRs to make it easier to review and test changes in isolation.The motivation for this new package is that it was hard to create a
*kgo.Clientthat could both produce and consume records. To fix this, the v2 client separates creating the client from creating the options, enabling the use of clients that produce, consume, and do both.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR