-
Notifications
You must be signed in to change notification settings - Fork 3.9k
perf: Fix memory leak in cachedIterator #17628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
approved these changes
Jun 12, 2025
ashwanthgoli
added a commit
that referenced
this pull request
Aug 1, 2025
This reverts commit 87aa954.
6 tasks
ashwanthgoli
added a commit
that referenced
this pull request
Aug 1, 2025
This reverts commit 87aa954.
ashwanthgoli
added a commit
that referenced
this pull request
Aug 1, 2025
6 tasks
6 tasks
ashwanthgoli
added a commit
that referenced
this pull request
Aug 1, 2025
…ort k265) (#18689) Co-authored-by: Ashwanth <iamashwanth@gmail.com>
chaudum
added a commit
that referenced
this pull request
Aug 1, 2025
…ort k264) (#18688) Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Ashwanth <iamashwanth@gmail.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes closing the wrapper iterator in cachedIterators when Close is called.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR