chore(engine): implement range aggregation operator #17997
Merged
+445
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwanthgoli
changed the title
chaudum
approved these changes
Jun 12, 2025
Comment on lines
+135
to
+138
| isTSInRange = func(t time.Time) bool { | ||
| // Aggregate entries that belong in [earliestTs, evalTs) | ||
| return t.Compare(earliestTs) >= 0 && t.Compare(evalTs) < 0 | ||
| } |
Contributor
There was a problem hiding this comment.
nit: You could create a helper struct like bloomshipper.Interval that has a Compare(t time.Time) method
Contributor
Author
There was a problem hiding this comment.
👍 we can add something like this when we add support for range queries
| } | ||
| tsCol := vec.ToArray().(*array.Timestamp) | ||
|
|
||
| for row := range int(record.NumRows()) { |
Contributor
There was a problem hiding this comment.
If the records where sorted by timestamp we could use binary search to determine start/end index 😑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
First version of range aggregation operator that only support count function for instant queries. It is implemented using a hash aggregation
I have left multiple TODOs but most of them are not immediate concerns.
Being able to return partial aggregate results on each Read call is something I'll look into in a follow-up PR.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR