chore: Define an E2E ingestion processing time metric #20054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
approved these changes
Nov 28, 2025
| // Update offset metric at the end of processing | ||
| defer p.metrics.updateOffset(record.Offset) | ||
|
|
||
| if record.Timestamp.Before(p.earliestRecordTime) || p.earliestRecordTime.IsZero() { |
Contributor
There was a problem hiding this comment.
if record.Timestamp.Before(p.earliestRecordTime)
This condition should be impossible as records are ordered and timestamps assigned by the broker?
I'm happy to ignore it for now, but it would be great if we could validate this at some point.
Contributor
Author
There was a problem hiding this comment.
I thought the same. I'm fairly sure its impossible, but in case we ever switch to processing from multiple partitions I decided to keep this in
|
|
||
| func getEarliestIndexedRecord(logger log.Logger, events []metastore.ObjectWrittenEvent) time.Time { | ||
| var earliestIndexedRecordTime time.Time | ||
| for _, ev := range events { |
Contributor
There was a problem hiding this comment.
Can len(events) ever be 0?
Contributor
Author
There was a problem hiding this comment.
It's unlikely but possible I think... Let me guard against setting the metric from a zero time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Creates a metric containing E2E processing time: The time between a log line hitting the distributor and it being available for querying by the new engine.