chore: split out golangci-lint in CI #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dedicated GitHub action does a much better job of caching and will be considerably faster.
sd2k
force-pushed
the
split-linters-in-ci
branch
from
446a17c to
b740812
Compare
dimitarvdimitrov
approved these changes
Jul 24, 2025
| TLSConfig: tlsConfig, | ||
| } | ||
| ctx = mcpgrafana.WithGrafanaConfig(ctx, config) | ||
| _ = ctx // Use ctx to avoid ineffectual assignment warning |
There was a problem hiding this comment.
Nit: the example below says that what the transport may be used for. Maybe yiu can say the same about the ctx here
| } | ||
| defer res.Body.Close() | ||
| defer func() { | ||
| _ = res.Body.Close() //nolint:errcheck // Ignore close error in defer |
There was a problem hiding this comment.
Nit but the comment doesn't really say anything useful 😄
sd2k
added a commit
that referenced
this pull request
Jul 24, 2025
These were added by Claude in #217.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dedicated GitHub action does a much better job of caching and
will be considerably faster.
This also removes the go.tools.mod way of running things because it's discouraged by the golangci-lint docs.