feat: add support for https when using streamable-http transport #270
+127
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcp-go v0.39.0 adds support for https when using the streamable-http transport. This commit adds support for configuring the server to serve https using custom certificates via the CLI. Fixes #244.
svennergr
approved these changes
Sep 2, 2025
| server.WithEndpointPath(endpointPath), | ||
| ) | ||
| } | ||
| if tls.certFile != "" || tls.keyFile != "" { |
There was a problem hiding this comment.
Suggested change
| if tls.certFile != "" || tls.keyFile != "" { | |
| if tls.certFile != "" && tls.keyFile != "" { |
Just a nit, but this seems to be a condition in mcp-go. You can also leave it, to actually return mcp-go's error message.
There was a problem hiding this comment.
Huh yeah, I thought I'd used your logic already but evidently not. I think I actually prefer just using mcp-go's error message though. Thanks for spotting!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcp-go v0.39.0 adds support for https when using the streamable-http
transport. This commit adds support for configuring the server to
serve https using custom certificates via the CLI.
Fixes #244.