Skip to content

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Aug 5, 2025

What this PR does / why we need it:

Frontend platform have removed @grafana/tsconfig from Grafana core. Whilst it continues to be used across many repos the next biggest consumer of the package is plugins.

Rather than plugins platform having to maintain multiple repos it makes more sense to move the tsconfig into plugin-tools.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@jackw jackw self-assigned this Aug 5, 2025
@jackw jackw added chore Other changes that don't modify src or test files no-changelog Don't include in changelog and version calculations labels Aug 5, 2025
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Aug 5, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

@jackw jackw force-pushed the jackw/import-tsconfig branch from 25b6d4d to 07dbff1 Compare August 6, 2025 07:15
@grafana grafana deleted a comment from CLAassistant Aug 6, 2025
@jackw jackw moved this from 📬 Triage to 🧑‍💻 In development in Plugins Platform / Grafana Community Aug 6, 2025
@jackw jackw marked this pull request as ready for review August 6, 2025 14:34
@jackw jackw requested review from a team as code owners August 6, 2025 14:34
Copy link
Contributor

@joshhunt joshhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@github-project-automation github-project-automation bot moved this from 🧑‍💻 In development to 🔬 In review in Plugins Platform / Grafana Community Aug 6, 2025
@jackw jackw force-pushed the jackw/import-tsconfig branch from 1dcdf30 to 75aaa37 Compare September 4, 2025 10:02
@jackw jackw force-pushed the jackw/import-tsconfig branch from 75aaa37 to 1e22af2 Compare September 24, 2025 13:51
@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 14:20
@jackw jackw force-pushed the jackw/import-tsconfig branch from 1e22af2 to 9b17bb5 Compare October 20, 2025 14:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR imports the @grafana/tsconfig package from Grafana core into the plugin-tools repository, making it easier for the plugins platform to maintain TypeScript configuration in a single location.

  • Adds a new @grafana/tsconfig package with TypeScript configuration files
  • Integrates the package into the monorepo workspace structure
  • Updates documentation to reference the new package

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/tsconfig/tsconfig.json Main TypeScript config extending base configuration
packages/tsconfig/package.json Package metadata and configuration for npm publishing
packages/tsconfig/base.json Base TypeScript compiler options
packages/tsconfig/README.md Documentation for package usage
packages/tsconfig/LICENSE Apache 2.0 license file
packages/tsconfig/CONTRIBUTING.md Contributing guidelines for the tsconfig package
package.json Adds tsconfig package to workspace configuration
README.md Adds tsconfig package to main documentation table
CONTRIBUTING.md Updates contributing guide with tsconfig package reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

jackw and others added 2 commits October 20, 2025 16:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jackw jackw merged commit 944d355 into main Oct 20, 2025
24 checks passed
@jackw jackw deleted the jackw/import-tsconfig branch October 20, 2025 14:43
@github-project-automation github-project-automation bot moved this from 🔬 In review to 🚀 Shipped in Plugins Platform / Grafana Community Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Other changes that don't modify src or test files no-changelog Don't include in changelog and version calculations

Projects

Status: 🚀 Shipped

Development

Successfully merging this pull request may close these issues.

8 participants