Conversation
added 2 commits
January 9, 2023 11:42
academo
commented
Jan 9, 2023
|
|
||
| var Analyzer = &analysis.Analyzer{ | ||
| Name: "archivename", | ||
| Name: "binarypermissions", |
Collaborator
Author
There was a problem hiding this comment.
I missed this in my previous PR. It is not strictly part of these changes but fixes error reporting.
academo
commented
Jan 9, 2023
|
|
||
| licenses, err := licensedb.Detect(filer) | ||
| if err != nil { | ||
| pass.ReportResult(pass.AnalyzerName, licenseNotProvided, "License not found", "Could not find or parse the license file inside the plugin archive. Please make sure to include a LICENCE file in your archive.") |
Collaborator
Author
There was a problem hiding this comment.
I am reporting this and the following as errors instead of returning the error. Returning the error will stop the whole plugincheck process to stop checking.
added 2 commits
January 9, 2023 11:52
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/grafana/community-pipeline/issues/26
Add license detection and validation for plugins