Skip node_modules entries in manifest validation#539
Merged
Conversation
Allow existing plugins to pass validation without rebuild by ignoring manifest entries under the root node_modules/ directory. These files are not part of the backend code and should not be included in validation. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
|
academo
approved these changes
Mar 11, 2026
github-project-automation
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
xnyo
approved these changes
Mar 11, 2026
Replace the broad node_modules/ prefix skip with an explicit list of ignored manifest files. Currently only the known flatted package path is ignored, making it easy to add more paths later if needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
academo
reviewed
Mar 11, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows already-published plugins to pass Go manifest validation without requiring a rebuild by ignoring manifest entries under the root
node_modules/directory. These files are not part of the backend code and should not be included in validation checks.