Skip to content

fix(ci): skip goreleaser validate pipe for prefixed tags #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tolzhabayev merged 1 commit into from
May 8, 2026
Merged

fix(ci): skip goreleaser validate pipe for prefixed tags #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/release-mcp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,14 @@ jobs:
with:
distribution: goreleaser
version: latest
args: release --clean --config .goreleaser.mcp.yaml
# release-please tags look like `mcp/v0.1.2`, which GoReleaser's
# validate pipe can't parse as semver. Skip it; the archive name
# template uses `MCP_VERSION` directly and `release.mode:
# keep-existing` preserves release-please's notes.
args: release --clean --config .goreleaser.mcp.yaml --skip=validate
env:
GITHUB_TOKEN: ${{ steps.generate_token.outputs.token }}
# Override the parsed tag with the bare semver so GoReleaser's
# validation passes; the actual GitHub release tag is set via
# `release.tag` in .goreleaser.mcp.yaml.
GORELEASER_CURRENT_TAG: v${{ env.MCP_VERSION }}
GORELEASER_CURRENT_TAG: ${{ github.ref_name }}
MCP_VERSION: ${{ env.MCP_VERSION }}

release-mcp-to-npm:
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,15 @@ jobs:
with:
distribution: goreleaser
version: latest
args: release --clean
# release-please tags look like `plugin-validator/v0.42.0`, which
# GoReleaser's validate pipe can't parse as semver. Skip it; the
# archive name template uses `RELEASE_VERSION` directly and
# `release.mode: keep-existing` preserves release-please's notes.
args: release --clean --skip=validate
env:
GITHUB_TOKEN: ${{ steps.generate_token.outputs.token }}
RELEASE_VERSION: ${{ env.RELEASE_VERSION }}
# Override the parsed tag with the bare semver so GoReleaser's
# validation passes; the actual GitHub release tag is set via
# `release.tag` in .goreleaser.yaml.
GORELEASER_CURRENT_TAG: v${{ env.RELEASE_VERSION }}
GORELEASER_CURRENT_TAG: ${{ github.ref_name }}

release-to-npm:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion .goreleaser.mcp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,3 @@ changelog:

release:
mode: keep-existing
tag: "mcp/v{{ .Version }}"
1 change: 0 additions & 1 deletion .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ changelog:
- "^test:"
release:
mode: keep-existing
tag: "plugin-validator/v{{ .Version }}"
# The lines beneath this are called `modelines`. See `:help modeline`
# Feel free to remove those if you don't want/use them.
# yaml-language-server: $schema=https://goreleaser.com/static/schema.json
Expand Down
Loading