feat: flush queue before next event polling #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eh-am
approved these changes
Oct 5, 2022
main.go
Outdated
| // profile the extension? | ||
| selfProfiling = getEnvBool("PYROSCOPE_SELF_PROFILING") | ||
|
|
||
| flushRelayQueue = getEnvBool("PYROSCOPE_FLUSH_RELAY_QUEUE") |
There was a problem hiding this comment.
This is false by default, my understanding is that this functionality has no clear downsides right? Shouldn't we make it true by default?
There was a problem hiding this comment.
The downside is that it can increase lambda invocation time and as a result billing. I'd keep it disabled by default. But it is not super strong opinion, we can change to enabled by default.
There was a problem hiding this comment.
Ahh I see now, since flush is sync, it makes the time before waiting for new events longer, therefore making it more expensive.
There was a problem hiding this comment.
maybe good idea to rename Flush to FlushSync so it is more obvious
eh-am
reviewed
Oct 7, 2022
Co-authored-by: eduardo aleixo <eh-am@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.