Skip to content

fix: configure MaxIdleConnsPerHost (was 2 by default) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix: configure MaxIdleConnsPerHost (was 2 by default) #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,12 @@ func main() {
ctx, cancel := context.WithCancel(context.Background())

// Init components
remoteClient := relay.NewRemoteClient(logger, &relay.RemoteClientCfg{Address: remoteAddress, AuthToken: authToken, Timeout: timeout})
remoteClient := relay.NewRemoteClient(logger, &relay.RemoteClientCfg{
Address: remoteAddress,
AuthToken: authToken,
Timeout: timeout,
MaxIdleConnsPerHost: numWorkers,
})
// TODO(eh-am): a find a better default for num of workers
queue := relay.NewRemoteQueue(logger, &relay.RemoteQueueCfg{NumWorkers: numWorkers}, remoteClient)
ctrl := relay.NewController(logger, queue)
Expand Down
14 changes: 10 additions & 4 deletions relay/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ var (

type RemoteClientCfg struct {
// Address refers to the remote address the request will be made to
Address string
AuthToken string
Timeout time.Duration
Address string
AuthToken string
Timeout time.Duration
MaxIdleConnsPerHost int
}

type RemoteClient struct {
Expand All @@ -34,12 +35,17 @@ func NewRemoteClient(log *logrus.Entry, config *RemoteClientCfg) *RemoteClient {
if timeout == 0 {
timeout = time.Second * 10
}

if config.MaxIdleConnsPerHost == 0 {
config.MaxIdleConnsPerHost = 5
}
return &RemoteClient{
log: log,
config: config,
client: &http.Client{
Timeout: timeout,
Transport: &http.Transport{
MaxIdleConnsPerHost: config.MaxIdleConnsPerHost,
},
},
}
}
Expand Down